Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix kernel issue #229

Merged
merged 5 commits into from
Aug 19, 2024
Merged

Fix kernel issue #229

merged 5 commits into from
Aug 19, 2024

Conversation

tpike3
Copy link
Member

@tpike3 tpike3 commented Aug 19, 2024

  • updates jupyter meta data to python3
  • ensures ipykernel in docs dependencies
  • ensure upstream is python kernel

@codecov Codecov
Copy link

codecov bot commented Aug 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.30%. Comparing base (ce501b6) to head (7cc65fe).
Report is 22 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #229      +/-   ##
==========================================
+ Coverage   78.21%   78.30%   +0.08%     
==========================================
  Files          10        9       -1     
  Lines         693      765      +72     
  Branches      151      173      +22     
==========================================
+ Hits          542      599      +57     
- Misses        127      131       +4     
- Partials       24       35      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

EwoutH
EwoutH approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@EwoutH EwoutH left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes Readthedocs is green!

(I always only approve on PRs, I will leave the merge to you or boyu, so you can merge the way you want)

@tpike3
Prevent nbsphinx run
6b95427 
update nbsphinx to prevent run
@tpike3
Update intro_tutorial.ipynb
3b728de 
improve visual of intro tutorial
@tpike3
Improve
7cc65fe 
Update import cell to remove install details
@tpike3
Copy link
Member Author

tpike3 commented Aug 19, 2024

OK, after some trial and error I got the tutorial so it looks more visually appealing and gets rid of a lot of the noise. Ready to merge.

@EwoutH EwoutH added the docs Release notes label label Aug 19, 2024
@EwoutH EwoutH merged commit e8f0490 into projectmesa:main Aug 19, 2024
12 checks passed
@wang-boyu wang-boyu mentioned this pull request Aug 19, 2024
Closed
@wang-boyu wang-boyu added this to the 0.8.0 milestone Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EwoutH EwoutH EwoutH approved these changes

Assignees
No one assigned
Labels
docs Release notes label
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tpike3 @EwoutH @wang-boyu